Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for checkbox #698

Closed
wants to merge 1 commit into from

Conversation

sundaram123krishnan
Copy link
Contributor

No description provided.

@jrmoulton
Copy link
Collaborator

jrmoulton commented Nov 27, 2024

These tests aren't really testing the checkbox. They are just testing that signals get updates.

I think for widgets the important api to test is the update method from the view trait and testing that directly.

Because the checkbox doesn't directly use the update method I don't think it needs any tests.

I'll close this for now but we are definitely interested in having tests for other widgets but proper testing isn't trivial yet. Some work probably needs to be done to ensure a proper test environment that works with window events and changes that require multiples passes

Thanks for opening the PR though!

@jrmoulton jrmoulton closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants